matthiasblaesing commented on PR #7248: URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2045601399
@sdedic thanks for taking a look! Feel free to fork. I'd also like to continue experimenting and so it would be good if you could create a separate PR. I'm still pondering whether it would be better to create one big "graalvm" module (this PR), that exposes its API or to keep the existing modules. What I'm not happy with in my current approach is: - The installer that basicly disables truffle compilation: https://github.com/apache/netbeans/blob/282401359ea15eeebb679f03ae83f7f39688a6c1/ide/libs.graalsdk/src/org/netbeans/libs/graalsdk/impl/Installer.java#L14-L15 - The removal of the `.system` graal module. Here I don't know whether or not this is a problem for GraalVM images (speed/usability) - The problems already mentioned by @lahodaj For one problem I saw the last few days, I think I found a solution yesterday: The services of the modules need to be exported, so that they can be found by the ServiceLoader of the NetBeans module system. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
