neilcsmith-net commented on PR #7451: URL: https://github.com/apache/netbeans/pull/7451#issuecomment-2160216966
> Consider a normal `ContextAwareAction`, this means a `ContextAwareAction` without state. In that case the IDE can spin up a huge number of `ContextAction`/`Performer` combinations. The `instDelegate` is only created when the action is actually being invoked. If that action now is "big" (for example because their target is huge), Well, "big" could mean a lot, including "big" to compute. But what do you mean by "target"? If that's in the lookup context then surely it's held by a strong reference anyway? Isn't the performer chain meant to invalidate and clear anyway when that reference goes from the context? I'm happy with the change you have, and it's probably the safer option. I retain a concern we're potentially masking issues with GC effects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
