eirikbakke commented on PR #7451: URL: https://github.com/apache/netbeans/pull/7451#issuecomment-2163249293
The changes look OK to me, reviewing each commit by itself. But the logic is complicated enough that I feel like correctness can only be ensured by manually testing it for some time. (I'm still waiting for https://issues.apache.org/jira/browse/NETBEANS-4754 to reappear without this PR or my earlier patch first. I have not yet been able to reproduce it... but I remember it was dependent on timing, memory conditions, and the phase of the moon...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
