eirikbakke commented on code in PR #7451:
URL: https://github.com/apache/netbeans/pull/7451#discussion_r1636605836
##########
platform/openide.awt/src/org/openide/awt/ContextAction.java:
##########
@@ -366,36 +363,10 @@ private Object delegate0(Lookup.Provider everything,
List<?> data, boolean getAc
}
instDelegate = new WeakReference<>(d);
} else {
- instDelegate = NONE;
+ instDelegate = null;
}
return d;
}
-
- void stopListeners() {
Review Comment:
Yeah, I looked through each of the sub-commits you mentioned, and the
analysis seems to make sense. There is a lot of dead code that never gets
called; I wonder if a call to attach() was accidentally left out at some point
in the original implementation?
Still, even if the code that is removed here was meant to be called at some
point, removing it now at least won't make things worse than they are, since it
is currently never called. So this cleanup makes sense to me as a first step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
