matthiasblaesing commented on PR #7659: URL: https://github.com/apache/netbeans/pull/7659#issuecomment-2289620095
@lahodaj @neilcsmith-net the idea looks sane to me. I share concerns about dependencies aswell though. But this might work: - Place the annotation `RegisterLSPServices` (we might want to bikeshed about the name) into `api.lsp`. That module is in the dependency tree anyway as you need it for `ErrorProvider` and the other LSP services. - The annotation process could then write an `*.instance` file into the MimeLookup for the annotated class, making it available to other modules - lsp.client could now read the entries from the MimeLookup and create the bridges So users of the module, that provides the `ErrorProvider`, don't get additional dependencies. Users that want to use the bridges load `lsp.client` and get them. This would leave the question whether or not the functionality should be in `lsp.client` or be split of into a separate module `lsp.support`. From my understanding this decision could be postponed, as it is possible to split a module at a later time and provide automatic dependencies, if that happens. @jtulach given the discussion here and in the mindset of being open for alternative implementation I would prefer to revert completely and restart with a clean approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
