lahodaj commented on PR #7659: URL: https://github.com/apache/netbeans/pull/7659#issuecomment-2290823615
First, I was thinking of putting this new stuff into a separate module, and that may happen, but I always thought it would depend on `lsp.client`, so using the API would automatically include `lsp.client` as well. (The advantage of this would be that would hopefully could break/remove the dependency between `lsp.client` and `api.lsp`, as this dependency seems not quite ideal to me either.) Not quite sure what's the issue with including `lsp.client` - the sole point of this annotation/opt-in is to say to `lsp.client`: "please provide language/editor features for this mime-type, by using the services registered for this mime type". To me, the annotation makes no sense at all without `lsp.client`. Maybe the idea is that this opt-in to use `lsp.client` would be sort-of optional for some language. But if that happens, wouldn't it be cleaner to have a bridge module for that language that would be enabled when `lsp.client` is present, and disabled otherwise. Overall, I don't think `api.lsp` is a good place for the annotation - that's the server part, which knows "nothing" about the GUI, and the annotation cannot deliver what it promises without `lsp.client`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
