neilcsmith-net commented on code in PR #7755:
URL: https://github.com/apache/netbeans/pull/7755#discussion_r1761789867
##########
nb/ide.branding/licenseinfo.xml:
##########
@@ -33,6 +32,13 @@
<file>core.startup/src/org/netbeans/core/startup/about_dark_nb.png</file>
<file>core.startup/src/org/netbeans/core/startup/frame48_dark_nb.gif</file>
<file>core.startup/src/org/netbeans/core/startup/frame_nb.gif</file>
+ <file>release/apache-netbeans.ico</file>
+ <file>release/apache-netbeans.svg</file>
+ <file>release/apache-netbeans1024.png</file>
+ <file>release/apache-netbeans256.png</file>
+ <file>release/apache-netbeans48.png</file>
+ <file>release/apache-netbeans512.png</file>
+ <file>release/netbeans.png</file>
<file>release/netbeans.icns</file>
<file>release/shortcuts.pdf</file>
<file>release/shortcuts_mac.pdf</file>
Review Comment:
Yes, I chose to use the name apache-netbeans to be clear about the official
icons, and left the two legacy paths the same, in case of external use.
And -1 to changing the semantics of the mac variant path. This has always
been the path to the macOS dock icon, and added to set -Xdock:icon in the
launcher script. It should remain as such. This path is certainly not two
releases old! If anyone really wants another .icns file, they can add it as
apache-netbeans.icns after this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
