mbien commented on code in PR #7755:
URL: https://github.com/apache/netbeans/pull/7755#discussion_r1761875592


##########
nb/ide.branding/licenseinfo.xml:
##########
@@ -33,6 +32,13 @@
         
<file>core.startup/src/org/netbeans/core/startup/about_dark_nb.png</file>
         
<file>core.startup/src/org/netbeans/core/startup/frame48_dark_nb.gif</file>
         <file>core.startup/src/org/netbeans/core/startup/frame_nb.gif</file>
+        <file>release/apache-netbeans.ico</file>
+        <file>release/apache-netbeans.svg</file>
+        <file>release/apache-netbeans1024.png</file>
+        <file>release/apache-netbeans256.png</file>
+        <file>release/apache-netbeans48.png</file>
+        <file>release/apache-netbeans512.png</file>
+        <file>release/netbeans.png</file>
         <file>release/netbeans.icns</file>
         <file>release/shortcuts.pdf</file>
         <file>release/shortcuts_mac.pdf</file>

Review Comment:
   yes the mac-os theme specific logo is 2 releases old, not the path itself 
which used to be the standard netbeans logo in the icns format.
   
   netbeans_21/nb:
   
![image](https://github.com/user-attachments/assets/1378d5ba-bd08-4514-ad38-4cd35377361f)
   
   I was just wondering why can't this be kept as in NB 21 and the mac-os theme 
specific icon would be added as `apache-netbeans_mac.icns`? (`_mac` since the 
shortcuts pdf already uses the postfix)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to