mbien commented on code in PR #7755:
URL: https://github.com/apache/netbeans/pull/7755#discussion_r1761986840
##########
nb/ide.branding/licenseinfo.xml:
##########
@@ -33,6 +32,13 @@
<file>core.startup/src/org/netbeans/core/startup/about_dark_nb.png</file>
<file>core.startup/src/org/netbeans/core/startup/frame48_dark_nb.gif</file>
<file>core.startup/src/org/netbeans/core/startup/frame_nb.gif</file>
+ <file>release/apache-netbeans.ico</file>
+ <file>release/apache-netbeans.svg</file>
+ <file>release/apache-netbeans1024.png</file>
+ <file>release/apache-netbeans256.png</file>
+ <file>release/apache-netbeans48.png</file>
+ <file>release/apache-netbeans512.png</file>
+ <file>release/netbeans.png</file>
<file>release/netbeans.icns</file>
<file>release/shortcuts.pdf</file>
<file>release/shortcuts_mac.pdf</file>
Review Comment:
> In case any macOS packaging (macports, homebrew, etc) still references the
legacy path to get the macOS dock icon.
and [flatpak](https://flathub.org/apps/org.apache.netbeans), gnome start
menus etc (https://github.com/apache/netbeans/issues/7734), since NB 22 when
the change happened
i guess we could file issues against the downstream packages - but i keep
wondering if simply reverting the file which was only mac specific for NB 22
and 23 and adding a dedicated mac file which is named accordingly for NB 24+
would be the easiest solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
