sid-srini commented on code in PR #7910:
URL: https://github.com/apache/netbeans/pull/7910#discussion_r1818128239


##########
java/java.hints/test/unit/src/org/netbeans/modules/java/hints/infrastructure/TreeRuleTestBase.java:
##########
@@ -242,9 +242,11 @@ protected String performFixTest(String fileName, String 
code, int pos, String er
         String realCode = toCheckDocument.getText(0, 
toCheckDocument.getLength());
         
         //ignore whitespaces:
-        realCode = realCode.replaceAll("[ \t\n]+", " ");
+        realCode = realCode.replaceAll("[ \t\r\n]+", " ");
 
         if (golden != null) {
+           //ignore CRLF/LF differences in golden:
+            golden = golden.replaceAll("[ \t\r\n]+", " ");

Review Comment:
   Thank you very much for your reviews.
   
   I'm happy to change to `\\s+` in the `realCode` preprocessing in this file, 
after testing it at my end.
   
   Regarding the goldenfiles, please advise me, pursuant to the discussion in 
the other comment. 
   For now I can test with just the *.gitattributes* change and leave the 
worrying about the future for the future. :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to