mbien commented on code in PR #7910:
URL: https://github.com/apache/netbeans/pull/7910#discussion_r1818145779
##########
java/java.source.base/test/unit/src/org/netbeans/modules/java/source/indexing/VanillaCompileWorkerTest.java:
##########
@@ -685,6 +685,7 @@ public void testPreserveValidMethods1() throws Exception {
" System.err.println(\"Hello, world!\");\n" +
" }\n" +
"}");
+ file2Fixed.replaceAll((k, v) -> v.replaceAll("\r\n", "\n"));
assertEquals(expected, file2Fixed);
Review Comment:
ah, we already use more than one file!
https://github.com/apache/netbeans/blob/master/php/.gitattributes
and this line would confirm our suspicion:
https://github.com/apache/netbeans/blob/059bba1752779436b07acdabc64cb19c518672d5/php/.gitattributes#L5
so we could try the same here and reduce the scope to the java cluster (and
check if all tests pass), or lower to only the modules which need it. Since
absolute paths seem to work, we could simply add it to the root file without
creating yet another file - maybe easier to maintain.
> Please let me know if I should go ahead and include the following change
to the .gitattributes file to set as binary (instead of text eol=lf):
don't use `binary` since reading the doc it sounds like it would affect more
than just the separators, lets keep `text` but lock it to `eol=lf` like the
`php` cluster does. I am curious if this already resolves the problem without
this PR applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
