mbien commented on code in PR #7910:
URL: https://github.com/apache/netbeans/pull/7910#discussion_r1818130310
##########
java/java.source.base/test/unit/src/org/netbeans/modules/java/source/indexing/VanillaCompileWorkerTest.java:
##########
@@ -685,6 +685,7 @@ public void testPreserveValidMethods1() throws Exception {
" System.err.println(\"Hello, world!\");\n" +
" }\n" +
"}");
+ file2Fixed.replaceAll((k, v) -> v.replaceAll("\r\n", "\n"));
assertEquals(expected, file2Fixed);
Review Comment:
> I checked it now and found that the goldenfiles in this package are named
with the extension .pass, in addition to .java.
this might be it indeed. Localized `.pass` files could be mixed with
portable Strings which causes trouble during comparison.
Unfortunately `.pass` files are used across the repo for other languages too
and we might not have enough coverage on windows to tweak the repo settings for
all of them. This is probably something we should do anyway but it doesn't have
to be in this PR.
Overall I am ok with the proposed changes here - it just looked a bit
suspicious to me that it is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
