neilcsmith-net commented on PR #7925: URL: https://github.com/apache/netbeans/pull/7925#issuecomment-2457656767
I agree with @mbien that the general idea is good, but that the implementation should perhaps mirror the navigator panel. I have mixed feelings there - I prefer the look of this, but not the inconsistency. More importantly, the actions should be registered in the layer system. Similarly to how the current popup menu is populated. See registrations under `ProjectTabActions` and `FilesTabActions` for the collapse action (https://github.com/apache/netbeans/blob/master/ide/projectui/src/org/netbeans/modules/project/ui/ProjectTab.java#L876). Other applications using these APIs might want to have different actions, or none at all. -1 from me for now on that point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
