s4gh commented on PR #7925: URL: https://github.com/apache/netbeans/pull/7925#issuecomment-2462863488
@neilcsmith-net I can change crosshair icon to be less like "+" something similar to icon in Idea (screenshot above) . I will look at the actions in more details. I am still learning how this all works. Some actions already exist. When you right click on the tab header of code editor there is "Select in Projects". Which means that this action already exists. But the "problem" is that it always opens this file in "Projects" view. While I am adding these icons to multiple view - right now it is already "Projects" and "Files". When I click the icon in "Files" view I can't use "Select in Projects" because it will open other view. I need something like "Select in Files". But "files" and "projects" views are not 2 different classes - they are implemented by the same class. So I still need to figure out how to call different actions from the same code depending on what view is used. At the moment I am not sure how I can know which view "projects" or "files" has focus now. For "Favorites" I need yet another action "Select in Favorites". For collapse all icon for "Files" and "Projects" there is already registered action. There is no need to register new one. I am not calling this functionality via "action" because this action is in the same file as my other code. So I simply can call same method which is used by action. So, in this case there is no code duplication, corresponding action already exists and I use the same method which is used by this action. Yes sure I can spend time on looking more into how actions work and try to find where "Favorites" view is implemented and change it as well. If you know file name please share. However this PR already has a lot of comments and some of the question whether this feets Netbeans or not. I am asking for decision to know what to do next. You already see UI and screenshots from other IDEs. And if this PR will not be accepted there is no need for me to spend time on trying to work on actions and "Favorites". I absolutely respect what you do and you have complete right accept something or not. I am asking to know if it makes sense for me to continue or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
