neilcsmith-net commented on PR #7925: URL: https://github.com/apache/netbeans/pull/7925#issuecomment-2460466482
> If you give "Navigator" view and it's toolbar at the bottom I do not really think this is consistent with any other panel. Which other panel has "toolbar" at the bottom? Debugger for one. Do a code search for `TapPanel` and you'll find various. > Also I will be appreciated for some examples how to register actions in layer system. This is my first PR attempt and I don't know much about Netbeans codebase yet. But more importantly if this PR will not be accepted anyway there is no sense for me to spend time trying to understand how "Favorites" view works :-) The actions are already registered. You need to reference them at some path (like a symlink). The link I previously shared shows how this is done for the popup menu. You'd add a reference at another path. Actions registered in a path can then be loaded via https://bits.netbeans.org/23/javadoc/org-openide-util-ui/org/openide/util/Utilities.html#actionsForPath-java.lang.String- They would need checking for `null` (used for separators) and buttons created out of them. How to link icons might be a concern though, as they might not work on the actions themselves. Possibly take a look at #7171 - that loads actions from a path and converts to buttons for the editor background. Although for various reasons, the actions are registered in an XML file rather than via `@ActionReference` in that one. I can't guarantee that your PR will be accepted, but I can say that it almost certainly won't be if platform developers using these views in other applications can't override the action selection and/or remove them from view entirely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
