neilcsmith-net commented on PR #8408: URL: https://github.com/apache/netbeans/pull/8408#issuecomment-2789079623
Thanks for looking at this. Generally (not tested yet) looks good. Have you tested with the platform launcher? IIRC this [extends the IDE launcher](https://github.com/apache/netbeans/blob/master/harness/apisupport.harness/windows-launcher-src/applauncher.h#L32) Need to make sure everything is still working as expected there, and that it's picking up the new basedir changes. When this is ready for merging, please add an additional commit mirroring the one at https://github.com/apache/netbeans/pull/8009/commits/272ebc2ab82c14970d5b9c8e1628de71cf7f8859 to update the various versions to `101.3.0.0`, `101300` or `101,3,0,0`. Happy to help get this through release vote once merged if you want me to? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
