neilcsmith-net commented on PR #8408: URL: https://github.com/apache/netbeans/pull/8408#issuecomment-2789693921
Assuming Windows platform launcher is picking up the change correctly, incidentally, this will need the platform Unix launcher altering too - https://github.com/apache/netbeans/blob/master/harness/apisupport.harness/release/launchers/app.sh#L36 That will need the same `$basedir` calculation adding I guess rather than relying on `../` The sooner we can consolidate launchers in one place the better! (hint, hint, @mbien :smile: ) > The variable substitution runs while the config is scanned line-by-line, this has the consequence that properties have to be defined in the right order, otherwise things will be missed. Setting `-J-Dmyhome=${netbeans_jdkhome}` does only work if `netbeans_jdkhome` is moved before `netbeans_default_options`. This is likely no problem in practice as long we are aware of this. Given that the Unix launcher sources the conf as a shell script, that's likely the right behaviour. I assume we don't want to support adding `rm -rf /` in the Windows conf as well though. :laughing: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
