mbien commented on PR #8408:
URL: https://github.com/apache/netbeans/pull/8408#issuecomment-2789540697
smoke test worked:
- installed temurin with default options (will set path but not java_home),
replaced launcher and NB started
- now I set `JAVA_HOME` to something else, started and it picked it up
- tested `${BASEDIR}` by adding it via `-J-Dfoo=${BASEDIR}` and checking
log for correct variable injection
looking through the code:
The variable substitution runs while the config is scanned line-by-line,
this has the consequence that properties have to be defined in the right order,
otherwise things will be missed. Setting `-J-Dmyhome=${netbeans_jdkhome}` does
only work if `netbeans_jdkhome` is moved before `netbeans_default_options`.
This is likely no problem in practice as long we are aware of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
