Re: [PR] vue files - include parametric embedding support for javascript and styles [netbeans]

[via GitHub]

haidubogdan commented on code in PR #8401:
URL: https://github.com/apache/netbeans/pull/8401#discussion_r2059238243


##########
webcommon/javascript2.vue/src/org/netbeans/modules/javascript2/vue/editor/embedding/VueHtmlEmbeddingProvider.java:
##########
@@ -61,12 +62,16 @@ public List<Embedding> getEmbeddings(final Snapshot 
snapshot) {
 
                 if (id.equals(VueTokenId.HTML)) {
                     embeddings.add(snapshot.create(ts.offset(), t.length(), 
TARGET_MIME_TYPE));
+                } else if (t.text() != null) {
+                    //issue with bracematcher
+                    String fake = new String(new 
char[t.text().toString().length()]).replace("\0", FILLER); //NOI18N
+                    embeddings.add(snapshot.create(fake, TARGET_MIME_TYPE));

Review Comment:
   Yes, here is an example.
   I see that it's mostly for javascript **script** tag.
   Maybe a mimepath bug also?
   
   
![image](https://github.com/user-attachments/assets/f651339d-0e0b-480b-af8c-142140311302)
   
   It seems to disturb the closing tag matcher position also.
   
![image](https://github.com/user-attachments/assets/b889715b-c549-4c04-bcf0-922cd16c7a26)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists