haidubogdan commented on code in PR #8401:
URL: https://github.com/apache/netbeans/pull/8401#discussion_r2072607107
##########
webcommon/javascript2.vue/src/org/netbeans/modules/javascript2/vue/editor/embedding/VueHtmlEmbeddingProvider.java:
##########
@@ -61,12 +62,16 @@ public List<Embedding> getEmbeddings(final Snapshot
snapshot) {
if (id.equals(VueTokenId.HTML)) {
embeddings.add(snapshot.create(ts.offset(), t.length(),
TARGET_MIME_TYPE));
+ } else if (t.text() != null) {
+ //issue with bracematcher
+ String fake = new String(new
char[t.text().toString().length()]).replace("\0", FILLER); //NOI18N
+ embeddings.add(snapshot.create(fake, TARGET_MIME_TYPE));
Review Comment:
The brace matcher issue is already exists on NB 26 RC-1. For the moment I
will mark this as resolved.
The issue is not clear, but so far what I notice that in the embedding
process (`HtmlBracesMatching`) the token '>' is received with the wrong offset.
And the token is coming from the TokenHierarchy.
I think I should also look at how HtmlLexerPlugin is implemented for
knockout js and Angular.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
