Re: [PR] vue files - include parametric embedding support for javascript and styles [netbeans]

[via GitHub]

haidubogdan commented on code in PR #8401:
URL: https://github.com/apache/netbeans/pull/8401#discussion_r2062386004


##########
webcommon/javascript2.vue/src/org/netbeans/modules/javascript2/vue/editor/embedding/VueHtmlEmbeddingProvider.java:
##########
@@ -61,12 +62,16 @@ public List<Embedding> getEmbeddings(final Snapshot 
snapshot) {
 
                 if (id.equals(VueTokenId.HTML)) {
                     embeddings.add(snapshot.create(ts.offset(), t.length(), 
TARGET_MIME_TYPE));
+                } else if (t.text() != null) {
+                    //issue with bracematcher
+                    String fake = new String(new 
char[t.text().toString().length()]).replace("\0", FILLER); //NOI18N
+                    embeddings.add(snapshot.create(fake, TARGET_MIME_TYPE));

Review Comment:
   The script part is easy to fix but for :
   
   
![image](https://github.com/user-attachments/assets/d1499347-21db-4f5c-8883-dbc5defb180a)
   
   Seems to be a issue with the fact that there is no offset check.
   
   Unfortunately the issue is already in the vue implementation from nb 26-rc1, 
but somehow I didn't notice it.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists