lkishalmi opened a new pull request, #8480:
URL: https://github.com/apache/netbeans/pull/8480

   Well, was checking why the NetBeans Snap build from sources does not build 
any more.
    
   It fails with:
   ```
        [exec] :: -compile-copyap:
        [exec] ::     [mkdir] Created dir: 
/root/parts/build/build/apisupport/apisupport.ant/build/copyapclasses
        [exec] ::  [nb-javac] Compiling 1 source file to 
/root/parts/build/build/apisupport/apisupport.ant/build/copyapclasses
        [exec] ::  [nb-javac] Ignoring source, target and bootclasspath as 
release has been set
        [exec] :: [nb-ext-jar] Building jar: 
/root/parts/build/build/apisupport/apisupport.ant/build/copyap.jar
        [exec] ::
        [exec] :: init:
        [exec] ::
        [exec] :: -prepare-mandatory-files-for-module:
        [exec] ::     [mkdir] Created dir: 
/root/parts/build/build/apisupport/apisupport.ant/build/classes/META-INF
        [exec] :: [createlicensesummary] All tests passed
        [exec] ::
        [exec] :: up-to-date:
        [exec] ::
        [exec] :: -pre-compile:
        [exec] ::
        [exec] :: -do-compile:
        [exec] ::  [nb-javac] Compiling 153 source files to 
/root/parts/build/build/apisupport/apisupport.ant/build/classes
        [exec] ::  [nb-javac] Ignoring source, target and bootclasspath as 
release has been set
        [exec] ::    [repeat] 
/root/parts/build/build/apisupport/apisupport.ant/src/org/netbeans/modules/apisupport/project/Evaluator.java:63:
 error: package org.netbeans.nbbuild.extlibs does not exist
        [exec] ::    [repeat] import 
org.netbeans.nbbuild.extlibs.SetupLimitModulesProbe;
        [exec] ::    [repeat]                                    ^
        [exec] ::    [repeat] 1 error
        [exec] ::   [nbmerge] Failed to build target: all-apisupport.ant
   ```
   
   So I was looking for the `SetupLimitModulesProbe` class and found PR #7201 .
   
   As a seasoned build engineer I found this a weird way to solve some a 
classic class duplication issue without declaring dependencies.
   
   I know that we are trained to do things DRY. Also annotation processors are 
on the blurred line of a build tool and a compiler.
   
   Though in this case  I think a well documented code duplication would be 
much cleaner solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to