mbien commented on PR #8480:
URL: https://github.com/apache/netbeans/pull/8480#issuecomment-2850438654

   doesn't ant have a copy task somewhere? I think asm is also copied around so 
it might work with a source file too,
   
   btw I see this class only in one jar:
   ```
   sh search-jars.sh SetupLimitModulesProbe.class
   searching for 'SetupLimitModulesProbe.class'
   nbbuild/netbeans/apisupport/modules/org-netbeans-modules-apisupport-ant.jar
        7324  2025-05-02 23:35   
org/netbeans/nbbuild/extlibs/SetupLimitModulesProbe.class
   ```
   but maybe my script can't find it.
   
   > +1 DRY is sometimes fundamentally overrated.
   
   I wouldn't say its overrated, but sometimes it is ok to break rules.
   
   I mentioned during review that we could try to find a way to deduplicate the 
file but I hoped for something simpler tbh :) 
https://github.com/apache/netbeans/pull/7201#issuecomment-2059734119


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to