mbien commented on PR #8480: URL: https://github.com/apache/netbeans/pull/8480#issuecomment-2852153013
> it is fundamentally overrated imo taking this repo as example I disagree with this phrasing. If you don't try to deduplicate you have to fix things multiple times. As someone who does project wide refactorings (e.g due to https://github.com/apache/netbeans/issues/8256) I might have more awareness to those issues than others e.g if I see the same piece of code 5 times in a diff - some of them with bug fixes. Or see the diff panel appear multiple times across NB with some having correct "diff to" ordering. As I said before: if there is no easy way to share this file, fine lets take the lesser evil. But copy and paste is not a overrated problem in my opinion. Whole modules (https://github.com/apache/netbeans/pull/7958) were copied and had to be deduplicated again with extra effort. JShell integration injects copied JDK code etc. I am ok with this PR but don't agree with the assessment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
