BalmungSan commented on code in PR #258:
URL: https://github.com/apache/incubator-pekko/pull/258#discussion_r1143689291
##########
project/JdkOptions.scala:
##########
@@ -74,9 +68,7 @@ object JdkOptions extends AutoPlugin {
jdk8home,
fullJavaHomes,
Nil,
- // '-release 8' would be a neater option here, but is currently not an
- // option because it doesn't provide access to `sun.misc.Unsafe` #27079
- (java8home: File) => Seq("-source", "8", "-target", "8",
"-bootclasspath", java8home + "/jre/lib/rt.jar"))
+ (java8home: File) => Seq("-source", "8", "-target", "8"))
Review Comment:
It will not use the **JDK 11** signature because it was compiled targeting
the **JDK 8**. It can't even see such a signature.
That is the whole point of the `release` flag, to ensure that both the
bytecode and linked **Java** lib match the target **JDK** version.
See https://github.com/scala/scala/pull/9982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
