He-Pin commented on code in PR #258:
URL: https://github.com/apache/incubator-pekko/pull/258#discussion_r1143804716
##########
project/JdkOptions.scala:
##########
@@ -74,9 +68,7 @@ object JdkOptions extends AutoPlugin {
jdk8home,
fullJavaHomes,
Nil,
- // '-release 8' would be a neater option here, but is currently not an
- // option because it doesn't provide access to `sun.misc.Unsafe` #27079
- (java8home: File) => Seq("-source", "8", "-target", "8",
"-bootclasspath", java8home + "/jre/lib/rt.jar"))
+ (java8home: File) => Seq("-source", "8", "-target", "8"))
Review Comment:
> @som-snytt Since you made the PR at
https://github.com/scala/scala/pull/9982 maybe you can comment on this?
https://github.com/scala/scala/pull/10109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
