pjfanning commented on code in PR #150:
URL:
https://github.com/apache/incubator-pekko-http/pull/150#discussion_r1204249991
##########
docs/src/test/scala/docs/http/scaladsl/HttpClientExampleSpec.scala:
##########
@@ -318,9 +323,10 @@ class HttpClientExampleSpec extends AnyWordSpec with
Matchers with CompileOnlySp
import pekko.http.scaladsl.unmarshalling.Unmarshal
import pekko.http.scaladsl.marshallers.sprayjson.SprayJsonSupport._
import spray.json.DefaultJsonProtocol._
+ import spray.json.RootJsonFormat
case class Pet(name: String)
- implicit val petFormat = jsonFormat1(Pet)
+ implicit val petFormat: RootJsonFormat[Pet] = jsonFormat1(Pet.apply)
Review Comment:
it might be worth having a test in scala-2 specific test source that ensure
that `implicit val petFormat = jsonFormat1(Pet)` still works for Scala 2 users
- we can log this as a separate issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
