mdedetrich commented on code in PR #150:
URL:
https://github.com/apache/incubator-pekko-http/pull/150#discussion_r1206618522
##########
http-core/src/main/scala/org/apache/pekko/http/impl/util/Rendering.scala:
##########
@@ -232,7 +233,7 @@ private[http] trait Rendering {
/**
* Renders the given string in double quotes.
*/
- def ~~#!(s: String): this.type = ~~('"').putEscaped(s) ~~ '"'
+ def ~~#!(s: String): this.type = this.~~('"').putEscaped(s, Rendering.`\"`,
'\\').~~('"')
Review Comment:
Thanks. Not sure if it makes sense to go through every comment that I marked
as suspicious, I was just concerned whether a regression was made when dealing
with the merge conflicts.
If you think all of the suspicious parts I marked are legitimate just let me
know and we can finally review and merge the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
