pjfanning commented on code in PR #150:
URL:
https://github.com/apache/incubator-pekko-http/pull/150#discussion_r1204278640
##########
project/Dependencies.scala:
##########
@@ -45,11 +46,19 @@ object Dependencies {
object Provided {
val jsr305 = "com.google.code.findbugs" % "jsr305" % "3.0.2" % "provided"
// ApacheV2
- val scalaReflect =
ScalaVersionDependentModuleID.versioned("org.scala-lang" % "scala-reflect" % _
% "provided") // Scala License
+ val scalaReflect = ScalaVersionDependentModuleID.fromPF {
+ case v if v.startsWith("2.") => "org.scala-lang" % "scala-reflect" % v %
"provided" // Scala License
+ }
}
object Compile {
- val scalaXml = "org.scala-lang.modules" %% "scala-xml" % "1.3.0" // Scala
License
+ val scalaXml = {
+ val xml = "org.scala-lang.modules" %% "scala-xml" // Scala License
Review Comment:
since we are doing a v1.0.0 release and we can afford to have some changes -
would it make sense to just upgrade and use the newer jar versions for all
Scala versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
