raboof commented on code in PR #150: URL: https://github.com/apache/incubator-pekko-http/pull/150#discussion_r1206668580
########## docs/src/test/scala/docs/http/scaladsl/server/directives/RouteDirectivesExamplesSpec.scala: ########## Review Comment: This change was part of 63b34370483aab3e10716e031d98c75c1bfc2e40. The `Content-Type` case class constructor is `private[http]`, because people are supposed to use the HttpEntity subclass to access it, rather than looking at the headers themselves. Apparently this was somehow not always correctly enforced on Scala 2. On Scala 3 this appears to have been fixed, so the test wouldn't compile as-is anymore, and it seemed more 'realistic' to switch to a different header to test the route directives. If it turns out there are legitimate use cases for constructing `Content-Type` header objects we might consider removing the `private[http]` from that constructor, but for now it seems conservative to keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
