raboof commented on code in PR #150:
URL:
https://github.com/apache/incubator-pekko-http/pull/150#discussion_r1206637535
##########
docs/src/test/scala/docs/http/scaladsl/server/directives/JsonStreamingExamplesSpec.scala:
##########
@@ -218,7 +222,7 @@ class JsonStreamingExamplesSpec extends RoutingSpec with
CompileOnlySpec {
.runFold(0) { (cnt, _) => cnt + 1 }
complete {
- measurementsSubmitted.map(n => Map("msg" -> s"""Total metrics
received: $n"""))
+ measurementsSubmitted.map(n => s"""Total metrics received: $n""")
Review Comment:
This change was part of 63b3437048. It might indicate a change in behavior,
but likely it's a change in behavior between Scala versions rather than between
before and after the changes to the module. Since the `Map` to json encoding
doesn't seem super relevant to this particular test it seemed more productive
to just simplify it to a regular string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
