raboof commented on code in PR #150:
URL:
https://github.com/apache/incubator-pekko-http/pull/150#discussion_r1206644757
##########
docs/src/test/scala/docs/http/scaladsl/server/directives/JsonStreamingExamplesSpec.scala:
##########
@@ -218,7 +222,7 @@ class JsonStreamingExamplesSpec extends RoutingSpec with
CompileOnlySpec {
.runFold(0) { (cnt, _) => cnt + 1 }
complete {
- measurementsSubmitted.map(n => Map("msg" -> s"""Total metrics
received: $n"""))
+ measurementsSubmitted.map(n => s"""Total metrics received: $n""")
Review Comment:
Yes - specifically in having the implicits correctly pick up that the `Map`
can automatically be converted to a Json object and be Marshallable. It's not
useless to figure out and show how to make that work again, but the risk that
this is a bug that needs to be fixed rather than just something that would need
a change in the test code to work on Scala 3 feels relatively low.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
