He-Pin commented on code in PR #485: URL: https://github.com/apache/incubator-pekko/pull/485#discussion_r1264346080
########## actor/src/main/scala/org/apache/pekko/dispatch/ForkJoinPoolConstants.scala: ########## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.pekko.dispatch + +private[dispatch] object ForkJoinPoolConstants { + val MaxCap: Int = 0x7FFF // 32767 + val DefaultKeepAlive: Long = 60000 Review Comment: Java code style for the `Constants`. And why we have such a big value? the default fork join pool is expected to not run any blocking things, and blocking code should be managed. Move to `object PekkoForkJoinPool` maybe better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
