migesok commented on code in PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#discussion_r1265138401
##########
actor/src/main/resources/reference.conf:
##########
@@ -482,6 +482,10 @@ pekko {
# Setting to "FIFO" to use queue like peeking mode which "poll" or
"LIFO" to use stack
# like peeking mode which "pop".
task-peeking-mode = "FIFO"
+
+ # This config is new in Pekko v1.1.0 and only has an effect if you are
running with JDK 9 and above.
+ # Read the documentation on `java.util.concurrent.ForkJoinPool` to
find out more. Default in hex is 0x7fff.
+ maximum-pool-size = 32767
Review Comment:
Thank you! I see your point now about changing the existing behaviour. I
just want to suggest that instead of exposing `maximum-pool-size` directly, it
might be better to expose the spare thread count as JDK devs did for the global
pool. The default value could be similar to the current default (effectively no
limit at all).
Given that parallelism is calculated programmatically in the current Akka
FJP configurator, combining it with a `maximum-pool-size` when the values are
close might be inconvenient. Usually when you look at it, you think in the
terms of "how many parallel blocking operations I can afford, additionally to
the normal parallelism level".
I can contribute exposing `saturate` config in a separate PR later if this
one goes through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
