He-Pin commented on code in PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#discussion_r1264347883
##########
actor/src/main/resources/reference.conf:
##########
@@ -482,6 +482,10 @@ pekko {
# Setting to "FIFO" to use queue like peeking mode which "poll" or
"LIFO" to use stack
# like peeking mode which "pop".
task-peeking-mode = "FIFO"
+
+ # This config is new in Pekko v1.1.0 and only has an effect if you are
running with JDK 9 and above.
+ # Read the documentation on `java.util.concurrent.ForkJoinPool` to
find out more. Default in hex is 0x7fff.
+ maximum-pool-size = 32767
Review Comment:
These are huge too, will cause OOM on common 4core 8GB box
##########
actor/src/main/resources/reference.conf:
##########
@@ -482,6 +482,10 @@ pekko {
# Setting to "FIFO" to use queue like peeking mode which "poll" or
"LIFO" to use stack
# like peeking mode which "pop".
task-peeking-mode = "FIFO"
+
+ # This config is new in Pekko v1.1.0 and only has an effect if you are
running with JDK 9 and above.
+ # Read the documentation on `java.util.concurrent.ForkJoinPool` to
find out more. Default in hex is 0x7fff.
+ maximum-pool-size = 32767
Review Comment:
This is huge too, will cause OOM on common 4core 8GB box
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]