mdedetrich commented on code in PR #333:
URL:
https://github.com/apache/incubator-pekko-http/pull/333#discussion_r1364153053
##########
project/PekkoDependency.scala:
##########
@@ -44,6 +44,7 @@ object PekkoDependency {
case None =>
Option(System.getProperty("pekko.http.build.pekko.version")) match {
case Some("main") => mainSnapshot
+ case Some("snapshot-1.0.x") => snapshot10x
Review Comment:
> `main` is the name of the branch we are using for 1.1.x so calling the
option to use a 1.0.x snapshot something with the word `main` in it would be
very confusing
No its not, `main` points to the latest `main` branch which are snapshots
and the `mainSnapshot` function finds the latest snapshot version from that
`main` branch (thats why its called `main`). It is currently `1.1.x` but it
will change automatically to `1.2.x` (whenever it comes out) for example. There
is an argument the naming is confusing but if we want to change that lets do it
in another PR.
`default` points to whatever version you have specified in
`minimumPekkoVersion` (currently `1.0.0`).
Given that, I think that `1.0.x` is a better name then `main-1.0.x` but the
`snapshot` part is already implied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
