mdedetrich commented on code in PR #333:
URL:
https://github.com/apache/incubator-pekko-http/pull/333#discussion_r1375408761
##########
project/PekkoDependency.scala:
##########
@@ -114,11 +116,12 @@ object PekkoDependency {
ep.toInt,
maj.toInt,
min.toInt,
- Option(tagNumber).map(_.toInt),
+ Option(tagNumber).map(_.toInt).getOrElse(Integer.MAX_VALUE),
Review Comment:
Okay, but how is `Integer.MAX_VALUE` going to provide a correct value here,
or am I missing something? Is it just some sentinel value that will get ignored
later (if so add a comment because logic/reasoning behind it is unclear).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
