mdedetrich commented on code in PR #333:
URL:
https://github.com/apache/incubator-pekko-http/pull/333#discussion_r1375408032
##########
project/PekkoDependency.scala:
##########
@@ -114,11 +116,12 @@ object PekkoDependency {
ep.toInt,
maj.toInt,
min.toInt,
- Option(tagNumber).map(_.toInt),
+ Option(tagNumber).map(_.toInt).getOrElse(Integer.MAX_VALUE),
Review Comment:
Why was this change needed? Is that part of
> adjusts the tagNumber logic to treat build numbers without an RC or M tag
as newer than ones that have then?
Don't see how using `Integer.MAX_VALUE` is correct for what its doing (i.e.
testing against latest found snapshot)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
