Roiocam commented on code in PR #1076:
URL: https://github.com/apache/incubator-pekko/pull/1076#discussion_r1470673763


##########
project/PekkoDependWalker.scala:
##########
@@ -30,4 +32,10 @@ object PekkoDependWalker {
         ScopeKeyMatcher((Compile / packageBin).scopedKey, CheckBoth),
         ScopeKeyMatcher((CompileJdk9 / compile).scopedKey, CheckConfig))))
 
+  lazy val protobufV3Settings = Seq(
+    walkTasks := Seq(
+      WalkTask(
+        ScopeKeyMatcher(OsgiKeys.bundle.scopedKey, CheckTask),
+        ScopeKeyMatcher(AssemblyKeys.assembly.scopedKey, CheckTask))))

Review Comment:
   For modules that have applied this setting, it will enforce this:
   
   > When `OsgiKeys.bundle` executes, the `AssemblyKeys.assembly` will be 
before  `OsgiKeys.bundle` and execute too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to