mdedetrich commented on PR #1076: URL: https://github.com/apache/incubator-pekko/pull/1076#issuecomment-1916242520
@Roiocam So I don't want to stop the PR, but I just want to make you aware (if you aren't already) that there generally is an issue with how sbt-osgi interacts with other packaging type of tasks i.e. ssembly,multi-release-jar/jdk9 etc etc when it comes to ordering and there are long discussions on this i.e. * https://github.com/sbt/sbt-osgi/issues/104#issuecomment-1886077313 * https://github.com/sbt/sbt-osgi/issues/102#issuecomment-1882581926 The reason why I am pointing this out is that it _may_ make sense to take a step back and resolve this problem in a principled way within sbt-osgi (although this can be done later!). For example as a quick idea that came to the top of my head, it makes sense to add the capability of adding sbt `Configuration`'s aka Config's to sbt-osgi in a similar way that is done with [sbt-header](https://github.com/sbt/sbt-header?tab=readme-ov-file#adding-headers-to-files-in-other-configurations) so that sbt-osgi is aware of other configs and then can handle ordering issues accordingly/correctly Also note I am a maintainer on sbt-osgi so if you open up PR's there with tests I can review them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
