Roiocam commented on PR #1076:
URL: https://github.com/apache/incubator-pekko/pull/1076#issuecomment-1917488386

   > So we could replace them. This should fix the issues of JDK9 and assembly 
not executing issue because when we execute osgiBundle, we will execute 
compile/fullClasspath.
   
   Yes, I have confirm this, and the manifest has been keep too.
   
   ```diff
   > diff newpb/META-INF/MANIFEST.MF oldpb/META-INF/MANIFEST.MF
   5c5
   < Bnd-LastModified: 1706633706879
   ---
   > Bnd-LastModified: 1706633635527
   7c7
   <  0-8a759bad20240131-0054-SNAPSHOT",org.apache.pekko.protobufv3.internal.
   ---
   >  0-8a759bad20240130-2351-SNAPSHOT",org.apache.pekko.protobufv3.internal.
   9c9
   <  310-8a759bad20240131-0054-SNAPSHOT"
   ---
   >  310-8a759bad20240130-2351-SNAPSHOT"
   15c15
   < Specification-Version: 1.1.0-M0+310-8a759bad+20240131-0054-SNAPSHOT
   ---
   > Specification-Version: 1.1.0-M0+310-8a759bad+20240130-2351-SNAPSHOT
   22,23c22,23
   < Bundle-Version: 1.1.0.M0310-8a759bad20240131-0054-SNAPSHOT
   < Implementation-Version: 1.1.0-M0+310-8a759bad+20240131-0054-SNAPSHOT
   ---
   > Bundle-Version: 1.1.0.M0310-8a759bad20240130-2351-SNAPSHOT
   > Implementation-Version: 1.1.0-M0+310-8a759bad+20240130-2351-SNAPSHOT
   32c32
   <  20240131-0054-SNAPSHOT
   ---
   >  20240130-2351-SNAPSHOT
   ~
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to