mdedetrich commented on code in PR #1207:
URL: https://github.com/apache/incubator-pekko/pull/1207#discussion_r1528764028
##########
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/StreamOfStreams.scala:
##########
@@ -640,7 +640,12 @@ import pekko.util.ccompat.JavaConverters._
else substreamSource.push(elem)
}
} catch {
- case NonFatal(ex) => onUpstreamFailure(ex)
+ case NonFatal(ex) =>
+ decider(ex) match {
+ case Supervision.Resume => pull(in)
+ case Supervision.Stop => onUpstreamFailure(ex)
+ case Supervision.Restart => onUpstreamFailure(ex) // TODO
implement restart?
Review Comment:
> After I took a look at the code, I think we should handle
`Supervision.Restart` as the `Supervision.Resume`,be cause it happens in
`SubstreamHandler`
Does it matter? The code will be updated in
https://github.com/apache/incubator-pekko/pull/981? Currently it's a place
holder.
Or do you mean that in https://github.com/apache/incubator-pekko/pull/981
it should behave as you say?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
