mdedetrich commented on code in PR #1207:
URL: https://github.com/apache/incubator-pekko/pull/1207#discussion_r1528765865
##########
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/StreamOfStreams.scala:
##########
@@ -640,7 +640,12 @@ import pekko.util.ccompat.JavaConverters._
else substreamSource.push(elem)
}
} catch {
- case NonFatal(ex) => onUpstreamFailure(ex)
+ case NonFatal(ex) =>
+ decider(ex) match {
+ case Supervision.Resume => pull(in)
+ case Supervision.Stop => onUpstreamFailure(ex)
+ case Supervision.Restart => onUpstreamFailure(ex) // TODO
implement restart?
Review Comment:
> We should add test for at least ` Supervision.Resume ` and `
Supervision.Stop` strategy.
These already exist, only the case of throwing exception with
`Supervision.restart` being missed (check rest of file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
