He-Pin commented on code in PR #1207:
URL: https://github.com/apache/incubator-pekko/pull/1207#discussion_r1528856829
##########
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowSplitAfterSpec.scala:
##########
@@ -250,10 +248,10 @@ class FlowSplitAfterSpec extends StreamSpec("""
upstreamSubscription.sendNext(6)
substreamPuppet1.expectNext(6)
substreamPuppet1.expectComplete()
+ upstreamSubscription.sendNext(7)
Review Comment:
As the `downstreamSubscription.request(100)` , I think the orign test should
be right too, but its a little strange now ,that we need send the `next(7)` to
make the next sub source be ready.
I think we should call
```scala
private def pushSubstreamSource(): Unit = {
push(out, Source.fromGraph(substreamSource.source))
scheduleOnce(SubscriptionTimer, timeout)
substreamWaitingToBePushed = false
}
```
now inside the `SubstreamHandler#onPush` when the decision is `SplitAfter`
too to keep the behavior the same, as it just a dummy Source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
