pjfanning commented on code in PR #156:
URL:
https://github.com/apache/pekko-persistence-jdbc/pull/156#discussion_r1536784037
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala:
##########
@@ -117,7 +117,7 @@ class JdbcDurableStateStore[A](
db.run(queries.deleteFromDb(persistenceId).map(_ => Done))
def deleteObject(persistenceId: String, revision: Long): Future[Done] =
- db.run(queries.deleteFromDb(persistenceId).map(_ => Done))
+ db.run(queries.deleteBasedOnPersistenceIdAndRevision(persistenceId,
revision).map(_ => Done))
Review Comment:
I created https://github.com/apache/pekko/issues/1232 - is 1232 worth
delaying the 1.1.0-M1 release for? I don't think so, myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
