mdedetrich commented on code in PR #156:
URL:
https://github.com/apache/pekko-persistence-jdbc/pull/156#discussion_r1536786162
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala:
##########
@@ -117,7 +117,7 @@ class JdbcDurableStateStore[A](
db.run(queries.deleteFromDb(persistenceId).map(_ => Done))
def deleteObject(persistenceId: String, revision: Long): Future[Done] =
- db.run(queries.deleteFromDb(persistenceId).map(_ => Done))
+ db.run(queries.deleteBasedOnPersistenceIdAndRevision(persistenceId,
revision).map(_ => Done))
Review Comment:
> If the deletion operation is not allowed, there will be no warnings and
exceptions. I think we should notify users in some way, such as returning
Future[Boolean]
Isn't a better way that doesn't break binary compatibility to just return a
`Future.failed` with some sealed exception trait so users can get more
information?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
