pjfanning commented on code in PR #156:
URL:
https://github.com/apache/pekko-persistence-jdbc/pull/156#discussion_r1536787088
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala:
##########
@@ -117,7 +117,7 @@ class JdbcDurableStateStore[A](
db.run(queries.deleteFromDb(persistenceId).map(_ => Done))
def deleteObject(persistenceId: String, revision: Long): Future[Done] =
- db.run(queries.deleteFromDb(persistenceId).map(_ => Done))
+ db.run(queries.deleteBasedOnPersistenceIdAndRevision(persistenceId,
revision).map(_ => Done))
Review Comment:
can this be done in another PR? - it does not just affect the function that
I am working on - it affects a number of other functions
It also looks like a change that we would want to replicate across all our
persistence implementations. Some of them might already have Future failure
results for failures to delete but it's quite likely that they all quietly
ignore the fact that delete call deleted nothing.
I really think this is a set of changes in behaviour that should be
discussed publicly before we make them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
