raboof commented on code in PR #808:
URL: https://github.com/apache/pekko-connectors/pull/808#discussion_r1764610262
##########
build.sbt:
##########
@@ -392,7 +392,7 @@ lazy val docs = project
"hadoop.version" -> Dependencies.HadoopVersion,
"extref.github.base_url" ->
s"https://github.com/apache/pekko-connectors/tree/${if (isSnapshot.value) "main"
else "v" + version.value}/%s",
- "extref.pekko.base_url" ->
s"https://pekko.apache.org/docs/pekko/current/%s";,
+ "extref.pekko.base_url" ->
s"https://pekko.apache.org/docs/pekko/${Dependencies.PekkoBinaryVersion}/%s";,
Review Comment:
Now that I think about it more, I'm no longer sure that it's better to link
to the the Pekko version this is built against than the 'current' Pekko
version: because of binary compatibility it'll be common and recommended that
people use newer versions of Pekko with older versions of satellite libraries.
I'm not opposed though :)
##########
project/Dependencies.scala:
##########
@@ -32,7 +32,7 @@ object Dependencies {
val PekkoGrpcBinaryVersion = "1.1"
val PekkoHttpVersion = PekkoHttpDependency.version
val PekkoStreamsCirceVersion = "1.1.0"
- val PekkoHttpBinaryVersion = "1.0"
+ val PekkoHttpBinaryVersion = PekkoHttpVersion.take(3)
Review Comment:
Maybe
```
import sbt.librarymanagement.VersionNumber
VersionNumber(PekkoHttpVersion).take(2).mkString(".")
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
