pjfanning commented on code in PR #808:
URL: https://github.com/apache/pekko-connectors/pull/808#discussion_r1764692386


##########
build.sbt:
##########
@@ -392,7 +392,7 @@ lazy val docs = project
       "hadoop.version" -> Dependencies.HadoopVersion,
       "extref.github.base_url" -> 
s"https://github.com/apache/pekko-connectors/tree/${if (isSnapshot.value) "main"
         else "v" + version.value}/%s",
-      "extref.pekko.base_url" -> 
s"https://pekko.apache.org/docs/pekko/current/%s";,
+      "extref.pekko.base_url" -> 
s"https://pekko.apache.org/docs/pekko/${Dependencies.PekkoBinaryVersion}/%s";,

Review Comment:
   The idea is to point to the docs of the lib based on the version of that lib 
that we build with. As we have seen with the Pekko core docs and the redirect 
of current from 1.0 to 1.1 broke some links. This approach of not linking to 
current means things are more stable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to