raboof commented on code in PR #808:
URL: https://github.com/apache/pekko-connectors/pull/808#discussion_r1764700696
##########
build.sbt:
##########
@@ -392,7 +392,7 @@ lazy val docs = project
"hadoop.version" -> Dependencies.HadoopVersion,
"extref.github.base_url" ->
s"https://github.com/apache/pekko-connectors/tree/${if (isSnapshot.value) "main"
else "v" + version.value}/%s",
- "extref.pekko.base_url" ->
s"https://pekko.apache.org/docs/pekko/current/%s";,
+ "extref.pekko.base_url" ->
s"https://pekko.apache.org/docs/pekko/${Dependencies.PekkoBinaryVersion}/%s";,
Review Comment:
> As we have seen with the Pekko core docs and the redirect of current from
1.0 to 1.1 broke some links
I think we should avoid that in the future by leaving behind redirects,
though: while changing our own sites to link to specific version indeed avoids
some breakage, there might still be external links pointing to 'current'. It
might also be better for SEO. Additionally, in Akka we often noticed people
being confused because they were referring to outdated versions of the docs.
Having said that, I'm still OK with the change to the versioned docs - just
wanted to share my thoughts for consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
